604257 - implement arrow panel styling for linux

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[:Margaret Leibovic]

Bug 554937 created the arrow panel xul widget, but we still need to create gnomestripe styles for it.

The panel should be styled like the topmost panel in this mockup:
http://www.stephenhorlander.com/images/blog-posts/geolocation-icon/new-style-panels-2.png

Comment 1

[Karl Tomlinson (:karlt)]

Is the reason for using a panel rather than an in-window xul widget that the widget should be able to extend beyond the main window?

Styles such as indicated in the link above are possible on systems with compositing window managers if bug 408284 is fixed.

On other systems, only a 0/1 alpha mask is possible, leading to jagged egdes on rounded/diagonal corners.  Currently our implementation is very slow.
I suspect improvements are possible but there may still be some penalty.

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: Update Linux ArrowPanel Styling v01

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Screenshot of Linux ArrowPanels

Comment 4

[Stephen Horlander [:shorlander]]

Comment on attachment 486431 [details] [diff] [review]
Update Linux ArrowPanel Styling v01

I need to update this for recent changes.

Comment 5

[Dão Gottwald [:dao]]

Some basic arrow panel tyling for Linux has been added in bug 590073 (but is currently disabled because of bug 620658), so this probably doesn't need to block anymore.

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to comment #5)
> Some basic arrow panel tyling for Linux has been added in bug 590073 (but is
> currently disabled because of bug 620658), so this probably doesn't need to
> block anymore.

As pointed out in Comment 5 this is blocked by bug 620658 which is a [softblocker]. I don't think this can be a hardblocker in that case.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Resolved the issue in comment 6, but probably not the way you wanted. :) Still, we have a patch here that should be fine assuming bug 620658 is resolved, yes?

Comment 8

[Stephen Horlander [:shorlander]]

(In reply to comment #7)
> Resolved the issue in comment 6, but probably not the way you wanted. :) Still,
> we have a patch here that should be fine assuming bug 620658 is resolved, yes?

As Dão pointed out in comment 5 he added some basic Linux styling in bug 590073. Once that is re-enabled it I think it would adequately resolve this bug and I could file a followup for post 4.0 prettification.

Comment 9

[Dão Gottwald [:dao]]

styling re-enabled: http://hg.mozilla.org/mozilla-central/rev/a5f732abf109

Comment 10

[Neil Deakin]

The arrowpanels test should also be enabled on Linux as well.

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> The arrowpanels test should also be enabled on Linux as well.

done: http://hg.mozilla.org/mozilla-central/rev/9e3297bed92b

Comment 12

[George Carstoiu]

I was able to reproduce issue with latest trunk from 2 February, when arrow panel is placed in the bottom part of the screen. See Screenshot 1.

Observation:
 - after pressing drop-down button from doorhanger, the arrow panel is displayed correctly

Comment 13

[George Carstoiu]

Attachment: Screenshot 1

Comment 14

[Dão Gottwald [:dao]]

(In reply to comment #12)
> I was able to reproduce issue with latest trunk from 2 February, when arrow
> panel is placed in the bottom part of the screen. See Screenshot 1.

That's actually not this bug, please file a new one.

Comment 15

[George Carstoiu]

Please go to Bug 616502 and read Comment 15. There's a reference there pointing to this bug about fixing arrows in Linux.

Comment 16

[Dão Gottwald [:dao]]

?

Comment 17

[Dão Gottwald [:dao]]

Ah, I see what you mean. It's still not this bug. Attachment 509121 [details] can be reproduced on Windows as well.

Comment 18

[Aleksei Perepelkin [:chaos]]

Verified with Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre